[client] Add experimental support for userspace routing #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixmal
force-pushed
the
userspace-router
branch
from
1370bfb to
fb1a107
Compare
lixmal
force-pushed
the
userspace-router
branch
from
6bb583e to
2930288
Compare
There was a problem hiding this comment.
Copilot reviewed 41 out of 56 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- client/firewall/uspfilter/conntrack/udp_test.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/icmp_test.go: Evaluated as low risk
- client/firewall/create.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/tcp_test.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/common.go: Evaluated as low risk
- client/firewall/create_linux.go: Evaluated as low risk
- client/firewall/nftables/manager_linux.go: Evaluated as low risk
- client/firewall/uspfilter/allow_netbird.go: Evaluated as low risk
- client/firewall/manager/firewall.go: Evaluated as low risk
- client/firewall/uspfilter/allow_netbird_windows.go: Evaluated as low risk
- client/firewall/iptables/manager_linux.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/udp.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/common_test.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/tcp.go: Evaluated as low risk
- client/firewall/uspfilter/conntrack/icmp.go: Evaluated as low risk
Comments suppressed due to low confidence (2)
client/firewall/iface.go:15
- [nitpick] The method name GetDevice is ambiguous. It should be renamed to GetFilteredDevice to be more descriptive.
GetDevice() *device.FilteredDevice
client/firewall/iface.go:16
- [nitpick] The method name GetWGDevice is ambiguous. It should be renamed to GetWireGuardDevice to be more descriptive.
GetWGDevice() *wgdevice.Device
pappz
reviewed
Jan 22, 2025
pappz
previously approved these changes
Feb 5, 2025
|
pappz
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
New environment variables:
NB_DISABLE_USERSPACE_ROUTING: Disables userspace routingNB_FORCE_USERSPACE_ROUTER: Forces use of userspace routing even if native OS routing is availableNB_ENABLE_NETSTACK_LOCAL_FORWARDING: Enables forwarding to localhost in netstack modeNew flow
flowchart TB Start([Inbound Packet]) --> StatefulEnabled{Stateful Enabled?} StatefulEnabled -->|Yes| TrackedConn{Matches Tracked Connection?} TrackedConn -->|Yes| Accept1[Accept Packet] TrackedConn -->|No| LocalIP StatefulEnabled -->|No| LocalIP{Is Local IP?} LocalIP -->|Yes| PeerACL{Peer ACLs Allow?} PeerACL -->|Yes| NetstackMode{Netstack Mode?} PeerACL -->|No| Drop1[Drop Packet] NetstackMode -->|Yes| ForwardLocal[Forward to Local Stack] NetstackMode -->|No| Accept2[Accept Packet] LocalIP -->|No| RoutingEnabled{Routing Enabled?} RoutingEnabled -->|No| Drop2[Drop Packet] RoutingEnabled -->|Yes| NativeRouter{Native Router?} NativeRouter -->|Yes| Accept3[Accept Packet] NativeRouter -->|No| RouteACLs{Route ACLs Allow?} RouteACLs -->|Yes| Forward[Pass to Forwarder] RouteACLs -->|No| Drop3[Drop Packet]Example tracer output:
Issue ticket number and link
Checklist